create layout #456
Merged
create layout #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcts
requested changes
Jun 17, 2024
There was a problem hiding this comment.
A few comments:
- please setup your linter as there are some formatting issues. You can see them when you run
npm run lint. You can install Prettier and ESLint to automate this - there are some responsivness issues, please ensure the design work for all viewports (the smallest one 320px width mobile screen).
To address the responsiveness, I suggest to have a centered container of 800px that contains 2 400px cols. But when screenwidth is below 600px switches to having the content stacked in a single column again.
Other than that, great work!
|
fixed all error |
dcts
reviewed
Jun 18, 2024
|
This is because an error occurs during build.
… Message ID: ***@***.***
com>
|
dcts
reviewed
Jun 18, 2024
|
***@***.***/tailwindcss-scrollbar
…On Tue, Jun 18, 2024 at 5:44 PM dcts ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#456 (comment)>
:
> @@ -40,6 +40,7 @@
"react-redux": "^8.1.2",
"resize-observer-polyfill": "^1.5.1",
"tailwindcss": "3.3.2",
+ "tailwindcss-scrollbar": "^0.1.0",
Can you send a link to the NPM package used here?
—
Reply to this email directly, view it on GitHub
<#456 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A77GYERRWMKOZ6JO6DFJJ7TZICZ5BAVCNFSM6AAAAABJL2DV6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRWGY4DOOJVGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
i am waiting for your new feedback |
|
dcts
reviewed
Jun 19, 2024
dcts
reviewed
Jun 19, 2024
dcts
reviewed
Jun 19, 2024
added 3 commits
June 19, 2024 03:24
|
Great work, thank you for fixing all issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.