Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField does not animate properly #2

Open
NawarA opened this issue Dec 17, 2018 · 7 comments
Open

TextField does not animate properly #2

NawarA opened this issue Dec 17, 2018 · 7 comments

Comments

@NawarA
Copy link

NawarA commented Dec 17, 2018

Bug:

Classes are not being passed down properly on focus.

For example, if you click a TextField with variant outline, the class does not get passed down properly, so no animation effect is seen when using this library. Compare the behavior of a <TextField variant=filled> with a <TextField variant=filled> from the material-ui/core and you'll notice the difference in behavior.

Easy Fix:

Fix found at: final-form/react-final-form#294

Change inputProps to InputProps. Then everything works normally. Confirmed the fix works.

Can you please make this fix and release?

sfblaauw added a commit to sfblaauw/final-form-material-ui that referenced this issue Mar 16, 2019
@sfblaauw
Copy link

Has @NawarA saids this fix the animation. Please @Deadly0 let us know if you will merge this request. Thanks

@andidev
Copy link

andidev commented Mar 19, 2019

I can confirm that the fix works. From the docs
Skärmavbild 2019-03-19 kl  23 10 13

I guess InputProps is the correct prop to use?

@andidev
Copy link

andidev commented Mar 19, 2019

Btw this also messes up the placeholder text. It gets squashed with the label for some reason. The fix fixes this issue as well.

andidev added a commit to andidev/final-form-material-ui that referenced this issue Mar 19, 2019
@andidev
Copy link

andidev commented Mar 19, 2019

This bug also makes the a form value of a blank string submit as undefined (when it should submit as a blank string). The InputProps change fixes this as well.

@tobytraylor
Copy link

I've run into this issue as well. Thanks for the work around. One more vote for a merge.

@tobytraylor
Copy link

Oh no... is this project dead?

@zsolt-dev
Copy link

this issue is causing so many bugs and should be merged long time ago.

Is someone willing to fork this and maintain it?
Or just ask @Deadly0 to replace him as a maintainer

I would do it, but I do not know typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants