Fix range check compatibility mode when range finder frame is already visible #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guild is having issues in Wotlk Classic ICC Blood Prince Council with the range finder not showing players in range.
I believe this is due to the BPCouncil Mod choosing 12y range, and that not being a valid range in a restricted area such as a raid.
I think it is caused by the check I modified in this PR. If someone has the frame visible at the start of the fight (with maybe 8 yards selected), then at the time the mod choses 12 yards for the range, the frame is already visible and the compatibility conversion is not being done. The conversion of the range should only depend on
restrictionsActive
, not onnot textFrame:IsShown()
, i. e. be moved before the if statement in L898.I have validated the behaviour and the fix in a 2-player party in Violet Hold, I assume it will work the same in the raid.