New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Debsources Responsive #62
Conversation
375d2df
to
94ca5f1
Compare
94ca5f1
to
d1e7ce9
Compare
This is a big commit, please see devlog for around 01:28:00.
0519e76
to
db36820
Compare
This will help us get the code sorted. You can see my progress and see how I'm coming along, right in git.
c79e534
to
e1d7f04
Compare
6c58cc4
to
d15ea7f
Compare
@@ -4,7 +4,8 @@ | |||
https://anonscm.debian.org/gitweb/?p=qa/debsources.git;a=blob;f=AUTHORS;hb=HEAD | |||
License: GNU Affero General Public License, version 3 or above. | |||
#} | |||
{# copied from templates/index.html #} | |||
{# XXX copied from templates/index.html #} | |||
{# this should be a macro: repetitive code which makes change awkward #} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unnecessary comments from the code :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this, will push up soon to the related branches. I'll review diffs and make sure there's not much more
Heya, i reviewed a bit your PR. Generally good work nice.
Haven't taken the time yet to test this locally but i pulled on sourcesdev. The tests locally are ok for you? |
Thanks for review. I already wrote a reply to this but lost it somehow... Anyways:
I agree. Will do.
I don't have an autoformatting tool, I changed some things I felt were indented badly. However, if you disagree with specific instances I will certainly be open to change.
If I recall correctly there was already some debsources specific stuff in there. However, you're right really, it's the better standard thing to do. I'll change over to that. The only tests failing are failing on travis only and in master, as mentioned on the IRC. Nothing else is failing for me. |
Note that this is not ready to actually be pulled yet, but opening the PR allows people to easily keep an eye on changes without having to dig through stuff or host it on their local machine.
http://sourcesdev.debian.net should usually have an up to date hosted version of this, although recent commits may take time to pull.