New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document apt-get workaround #2

Merged
merged 8 commits into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@a3nm
Contributor

a3nm commented Oct 25, 2017

Hi, this is as discussed in issue #1. I also documented the need to install the dependencies of vmdb2, if that's OK.

By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?

Show outdated Hide outdated README.md Outdated
@stapelberg

This comment has been minimized.

Show comment
Hide comment
@stapelberg

stapelberg Oct 25, 2017

Contributor

Thanks for the PR!

By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?

Yeah, we should definitely recommend env -i and umask until https://github.com/larswirzenius/vmdb2/issues/26 is fixed upstream. Feel free to put that into this very PR, or submit a different one.

Contributor

stapelberg commented Oct 25, 2017

Thanks for the PR!

By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?

Yeah, we should definitely recommend env -i and umask until https://github.com/larswirzenius/vmdb2/issues/26 is fixed upstream. Feel free to put that into this very PR, or submit a different one.

@a3nm

This comment has been minimized.

Show comment
Hide comment
@a3nm

a3nm Oct 25, 2017

Contributor

I implemented your suggestion, thanks! As for the environment cleanup issue, I tried to explain how to do it, but with env -i it's a bit ugly because you need to keep some variables. What do you think?

I'm running a build now to check that the proposed invocation works until the end; if it does work I'm fine with merging.

Contributor

a3nm commented Oct 25, 2017

I implemented your suggestion, thanks! As for the environment cleanup issue, I tried to explain how to do it, but with env -i it's a bit ugly because you need to keep some variables. What do you think?

I'm running a build now to check that the proposed invocation works until the end; if it does work I'm fine with merging.

Show outdated Hide outdated README.md Outdated
@a3nm

This comment has been minimized.

Show comment
Hide comment
@a3nm

a3nm Oct 25, 2017

Contributor

I did your suggested change, thanks! The build seems to run, just checking now that it actually completes.

Contributor

a3nm commented Oct 25, 2017

I did your suggested change, thanks! The build seems to run, just checking now that it actually completes.

@stapelberg

This comment has been minimized.

Show comment
Hide comment
@stapelberg

stapelberg Oct 25, 2017

Contributor

Please let me know once you have a working image and I’ll merge. Thanks again!

Contributor

stapelberg commented Oct 25, 2017

Please let me know once you have a working image and I’ll merge. Thanks again!

@a3nm

This comment has been minimized.

Show comment
Hide comment
@a3nm

a3nm Oct 25, 2017

Contributor
Contributor

a3nm commented Oct 25, 2017

@stapelberg stapelberg merged commit 82d6b7e into Debian:master Oct 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment