Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Document apt-get workaround #2

Merged
merged 8 commits into from
Oct 25, 2017
Merged

Document apt-get workaround #2

merged 8 commits into from
Oct 25, 2017

Conversation

a3nm
Copy link
Contributor

@a3nm a3nm commented Oct 25, 2017

Hi, this is as discussed in issue #1. I also documented the need to install the dependencies of vmdb2, if that's OK.

By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?

README.md Outdated
`apt-get` invocations with `apt-get -o Acquire::Check-Valid-Until=false`
- If you want to use the latest versions of each software, you can replace
`http://snapshot.debian.org/archive/debian/20171007T213914Z/` in raspi3.yaml
with the URL of your favorite Debian mirror. Of course, this means that the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s,the URL of your favorite Debian mirror,http://deb.debian.org/debian, please. People who care about mirrors will know how to replace it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great idea! fixing

@stapelberg
Copy link
Contributor

Thanks for the PR!

By the way, one other thing that could maybe be documented is the fact that building the image fails mysteriously ("cannot run apt-key") if the user running the build has another umask that 022 (see here). I don't know whether you think it's a relevant point to document, but it's the main problem I had to debug when building the image. What do you think?

Yeah, we should definitely recommend env -i and umask until https://github.com/larswirzenius/vmdb2/issues/26 is fixed upstream. Feel free to put that into this very PR, or submit a different one.

@a3nm
Copy link
Contributor Author

a3nm commented Oct 25, 2017

I implemented your suggestion, thanks! As for the environment cleanup issue, I tried to explain how to do it, but with env -i it's a bit ugly because you need to keep some variables. What do you think?

I'm running a build now to check that the proposed invocation works until the end; if it does work I'm fine with merging.

README.md Outdated

```shell
umask 022
sudo env -i HOME="$HOME" LC_CTYPE="${LC_ALL:-${LC_CTYPE:-$LANG}}" PATH="$PATH" USER="$USER" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why $HOME and $USER are required? This strikes me as odd.

We should set LC_CTYPE=C.UTF-8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$HOME and $USER were probably not required, I just lost patience after $LT_CTYPE and $PATH so I searched for a solution online. Fixed.

@a3nm
Copy link
Contributor Author

a3nm commented Oct 25, 2017

I did your suggested change, thanks! The build seems to run, just checking now that it actually completes.

@stapelberg
Copy link
Contributor

Please let me know once you have a working image and I’ll merge. Thanks again!

@a3nm
Copy link
Contributor Author

a3nm commented Oct 25, 2017 via email

@stapelberg stapelberg merged commit 82d6b7e into Debian:master Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants