tests ok #6
Merged
tests ok #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edoumou
previously approved these changes
Sep 16, 2022
contracts/DebondToken.sol
Outdated
| @@ -255,4 +255,8 @@ abstract contract DebondToken is IDebondToken, ERC20, GovernanceOwnable { | |||
| ); | |||
| exchangeAddress = _exchangeAddress; | |||
| } | |||
|
|
|||
| function burn(uint amount) external { | |||
There was a problem hiding this comment.
I considered that the issue was the burn function was missing in the DebondToken contract. In that case, the burn function added by @toufic0710 to burn Debond tokens has no issue since it's similar to the mint function that was already there. Therefore, this function can be used safely.
drikssy
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a function which enable burning of dbit and dgov