Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support for collections with multiple folders #15

Merged
merged 28 commits into from Nov 2, 2023
Merged

fix: Support for collections with multiple folders #15

merged 28 commits into from Nov 2, 2023

Conversation

erowley7
Copy link
Contributor

@erowley7 erowley7 commented Nov 1, 2023

Added support for collections with multiple folders and for collections with no folders.
Added test to test both cases, with and without folders

erowley7 and others added 25 commits October 16, 2023 11:06
@erowley7
feat: newman results as pull request comment
74e371e
@erowley7
Added unit tests for Utils - buildPullRequestComment
1b8b18b
@erowley7
Pull Request Decathlon#13 ammendments
9d38a39
@erowley7
Ammendments to pull request Decathlon#13
afa688e
@erowley7
moved .catch to outside of Promise.allSettled
c7bf8c3
@erowley7
Removed un-needed variable 'firstPass' and moved getAssociatedPullReq…
664495e 
…uestNumberFromSha outside of the GithubService class
@erowley7
Removed redundant await
8401d0f
@erowley7
Modified getAssociatedPullRequestNumberFromSha method to use .then() …
a39dbda 
…to call the next api request
@erowley7
Removed Async, moved decoratePullRequest into PullRequestDecorator an…
598cf39 
…d split up the Promise.allSettled, added a command line option --reporter-enable-pullrequest-enable-comment
@erowley7
Ammended README, implemented pullrequest feedback
a4b5d93
@erowley7
Dummy Collection Deleted
0cd6f9d
@erowley7
Removed Async keyword and added a return for getAssociatedPullRequest…
5c6ef50 
…NumberFromSha
@erowley7
Pull Request Changes
5b8cd0d
@erowley7
ES Lint Fix
913fb5a
@erowley7
Added enablePullRequestComment to tests
4c65ee9
@erowley7
feat: added check link, ammended tests and the comment
1ca5c18
@erowley7
Reverted back to previous commit, added checkID to url and a hyperlin…
e04397f 
…k, improved readability in .lib/Util.js and altered order that requests are called in decoratePullRequest
@erowley7
Altered error comment message
275641e
@erowley7
Added tests for util.js
0abcf92
@erowley7
Added test for buildCheckPageUrl
512422a
@erowley7
Delete dummycollection.json
ae2a86d
@rbenhaddou
Merge branch 'main' into main
86203a1
@erowley7
es-lint fixes
5c03dc2
@erowley7
Added support for nested folders of requests
f586c5d
@erowley7
eslint fixes:
aefdc68
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ erowley7
❌ rbenhaddou
You have signed the CLA already but the status is still pending? Let us recheck it.

@rbenhaddou rbenhaddou merged commit 9944b16 into Decathlon:main Nov 2, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erowley7 @CLAassistant @rbenhaddou