Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertical padding for Snackbar component #90

Closed
3 tasks done
GerardPaligot opened this issue Sep 29, 2022 · 2 comments
Closed
3 tasks done

Add vertical padding for Snackbar component #90

GerardPaligot opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
android 🟒 Related to android bug πŸ› Something isn't working components 🧩 Related to components dev issues created βœ”οΈ Here to say that all developers issues had been created

Comments

@GerardPaligot
Copy link

GerardPaligot commented Sep 29, 2022

Duplicates ❌

  • I have searched the existing issues

Which Figma library is concerned?

Vitamin Android UI Kit

Current behavior 😯

The figma specification of Android Snackbar use a Ghost button without any vertical padding.

Expected behavior πŸ€”

We should add a top and bottom padding of 6dp for the button

Context πŸ”¦

The Android implementation can't respect the design specification described in Figma Android UI Kit project.

Screenshots / Videos πŸ“Έ

image

Tasks

  1. bug πŸ› run πŸ’¨
    FDELAHA24 GerardPaligot
  2. bug πŸ›
    apauchet
  3. bug πŸ› run πŸ’¨ wontfix 🚫
@GerardPaligot GerardPaligot added the bug πŸ› Something isn't working label Sep 29, 2022
@lauthieb
Copy link
Member

Thanks @GerardPaligot for your bug report.
We will investigate it as soon as possible.
Have a nice evening,
Laurent

@Sabrinavigil Sabrinavigil self-assigned this Oct 18, 2022
@lauthieb lauthieb changed the title [Bug]: Add vertical padding for Android Snackbar component Add vertical padding for Android Snackbar component Oct 19, 2022
@lauthieb lauthieb changed the title Add vertical padding for Android Snackbar component Add vertical padding for Snackbar component Oct 19, 2022
@Sabrinavigil
Copy link
Contributor

linked #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 🟒 Related to android bug πŸ› Something isn't working components 🧩 Related to components dev issues created βœ”οΈ Here to say that all developers issues had been created
Projects
Archived in project
Development

No branches or pull requests

4 participants