implement annas feedback #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxgr-linux
requested changes
Mar 11, 2024
src/components/partials/PageMenu.vue
Outdated
| @@ -19,7 +19,9 @@ | |||
| Download Gameclient | |||
| </RouterCCButton> | |||
| </div> | |||
| <LoginComponent /> | |||
| <LoginComponent | |||
| class="" | |||
src/views/LandingPage.vue
Outdated
| <div class="text-black text-3xl pt-4"> | ||
| <p>Crowd Control is a growing community based on open source and</p> | ||
| <p>collaboration. Learn the game and give us your review.</p> | ||
| <div class="h-[55rem] xl:h-[60rem] overflow-clip"> |
There was a problem hiding this comment.
Maybe that's something that should be done in the fade teaser itself. Would also be a good idea to incorporate this directly into my PR, since fade teaser behaviour is changed there.
There was a problem hiding this comment.
The fade teaser is used in different situations, sometimes as the whole background of a page (learn and other pages) and sometimes only as a fragment (landing page)
src/views/Learn.vue
Outdated
| @@ -1,12 +1,12 @@ | |||
| <template> | |||
| <div > | |||
| <FadeTeaser> | |||
| <div class="px-0 py-40 flex text-center justify-center"> | |||
There was a problem hiding this comment.
This should also not be done here, since TeaserHeader will be added in my PR, centralizing such behaviour.
src/views/NotFound.vue
Outdated
| @@ -1,6 +1,6 @@ | |||
| <template> | |||
| <div class="bg-black flex text-center justify-center h-[80vh]"> | |||
| <div class="my-auto"> | |||
| <div class="mt-24 my-auto"> | |||
lxgr-linux
reviewed
Mar 17, 2024
src/views/CardCreatorPage.vue
Outdated
| @@ -952,6 +953,32 @@ export default { | |||
| isEmpty(a) { | |||
| return R.isEmpty(a); | |||
| }, | |||
| getOBMask() { | |||
| console.log("model", this.model.type) | |||
There was a problem hiding this comment.
pls not so many console.logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.