Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model averaging fixed #3

Merged
merged 7 commits into from
Dec 19, 2021
Merged

model averaging fixed #3

merged 7 commits into from
Dec 19, 2021

Conversation

shaydeci
Copy link
Collaborator

@shaydeci shaydeci commented Nov 29, 2021 •
edited

When EMA is set, the model averaging should take the models used for validation (i.e the ema model).

lotem-deci
lotem-deci approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@lotem-deci lotem-deci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lotem-deci lotem-deci merged commit 2bff5bc into master Dec 19, 2021
@ranrubin ranrubin deleted the hotfix/DLE-881_ema_model_averaging branch January 13, 2022 20:13
@syedrz syedrz mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem-deci lotem-deci lotem-deci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaydeci @lotem-deci @ranrubin