Feature/sg 631 add registry collate funcs samplers #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added all_collate_functions.py to training.datasets for registy
shaydeci
requested changes
Jan 31, 2023
There was a problem hiding this comment.
Comment regarding more collate functions left out, inline.
More importantly, the fact you added a registry for collate functions iis great but not sufficient.
Suppose a user registers their collate functions, and we pass some string as an argument to train_dataloader_params. Will that string translate to the right collate function?
The answer is no. You need to resolve the right class by implementing a factory otherwise the registry is useless.
Guidance: see dataloaders.get(), find where we handle the dataloader_params processing and resolve the collate_fn argument with your new CollateFactory.
…ttps://github.com/Deci-AI/super-gradients into feature/SG-631_add_registry_collate_funcs_samplers
shaydeci
requested changes
Feb 2, 2023
ofrimasad
approved these changes
Feb 5, 2023
eran-deci
deleted the
feature/SG-631_add_registry_collate_funcs_samplers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.