cran comments, test

DeclareDesign · Nov 8, 2018 · d93df2a · d93df2a
1 parent 1e1e7c7
commit d93df2a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,21 +1,22 @@
 ## Submission
 
-We are submitting a small update, `DeclareDesign 0.12.0`. Thank you for your time reviewing the submission.
+We are resubmitting a small update, `DeclareDesign 0.12.0`, after minor errors were found during the CRAN checks in the submission processs. Thank you for your time reviewing the submission.
 
 We have addressed the notes and errors in the CRAN checks.
 
 ## Test environments
-* local OS X install, R 3.5.1
-* ubuntu 12.04 (on travis-ci), R 3.5.1
-* win-builder (devel and release)
+* local OS X install (release)
+* ubuntu 12.04 on travis-ci (devel, release, oldrel)
+* OS X on travis-ci (release, oldrel)
+* win-builder (devel, release, oldrel)
 
 ## R CMD check results
 
 0 errors | 0 warnings | 0 notes
 
 ## Reverse dependencies
 
-There is an issue in the `DesignLibrary` package, also maintained by us, and we are preparing a patch to address them in the coming days.
+There is an issue in the `DesignLibrary` package, also maintained by us, and we are preparing a patch to address it as soon as this is on CRAN.
 
 ---
 
diff --git a/tests/testthat/test-design-library.R b/tests/testthat/test-design-library.R
@@ -35,6 +35,7 @@ test_that("MH sim ids", {
 test_that("fan out IDs are correct", {
 
   skip_if_not_installed("DesignLibrary")
+  skip_on_cran()
 
   sims <- c(30, 1, 2, 1, 1, 2)
   design <- DesignLibrary::two_arm_designer(rho = 0)