New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fan out interpretation #268
Comments
propose: step_1_sim step_2_sim and that it prints all the step_*_sim columns regardless of whether the sim number varies. |
So just have duplicated columns in the output? :/ |
agree this is clear: step_1_sim step_2_sim
not too keen on printing all steps in output; output table quickly becomes
cluttered and think we should avoid uninformative content
…On Tue, Jul 3, 2018 at 5:21 PM Alexander Coppock ***@***.***> wrote:
propose:
step_1_sim step_2_sim
and that it prints all the step_*_sim columns regardless of whether the
sim number varies.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMJO_VQaftXIRE685hoxkcmzlQs1UT2bks5uC4vxgaJpZM4U0h8l>
.
|
maybe for a sims = c(5, 1, 1, 1, 1, 2) could be step_1_sim step_2_to_5_sim step_6_sim |
am still in favor of all steps rather than a subset. we never really print the steps, but it would be much clearer if the step number literally referred to the step number. |
I prefer Neal's suggestion to having all steps as separate vars. Neal's
suggestion *is* explicit for all steps and avoids a possibly large number
of columns with no information (otherwise columns step_2_sim ---
step_5_sim) would all have 1s. it is also more interpretable since you can
read off that step_1_sim and step_6_sim vary but step_2_to_5_sim does not
… sims = c(5, 1, 1, 1, 1, 2) could be step_1_sim step_2_to_5_sim step_6_sim
On Wed, Aug 22, 2018 at 1:29 AM Alexander Coppock ***@***.***> wrote:
am still in favor of all steps rather than a subset. we never really print
the steps, but it would be much clearer if the step number literally
referred to the step number.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#268 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMJO_d_Cfzs1jc5IELDAk1js7HsHioQdks5uTJe8gaJpZM4U0h8l>
.
|
There may be a risk that users think that fan_n refers to step n, or at least are confused by how many fans there are and what they mean
May be helped by indicating what the fans are in the design summary or perhaps by naming them by end-step or by exporting check_sims
thoughts?
The text was updated successfully, but these errors were encountered: