Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fan out interpretation #268

Closed
macartan opened this issue Jun 22, 2018 · 6 comments · Fixed by #335
Closed

fan out interpretation #268

macartan opened this issue Jun 22, 2018 · 6 comments · Fixed by #335
Milestone

Comments

@macartan
Copy link
Collaborator

There may be a risk that users think that fan_n refers to step n, or at least are confused by how many fans there are and what they mean
May be helped by indicating what the fans are in the design summary or perhaps by naming them by end-step or by exporting check_sims
thoughts?

@graemeblair graemeblair added this to the CRAN v1 release milestone Jun 24, 2018
@acoppock
Copy link
Collaborator

acoppock commented Jul 3, 2018

propose:

step_1_sim step_2_sim

and that it prints all the step_*_sim columns regardless of whether the sim number varies.

@nfultz
Copy link
Contributor

nfultz commented Jul 3, 2018

So just have duplicated columns in the output? :/

@macartan
Copy link
Collaborator Author

macartan commented Jul 3, 2018 via email

@graemeblair graemeblair modified the milestones: CRAN v1 release, future Jul 10, 2018
@nfultz
Copy link
Contributor

nfultz commented Aug 17, 2018

maybe for a sims = c(5, 1, 1, 1, 1, 2)

could be

step_1_sim step_2_to_5_sim step_6_sim

@acoppock
Copy link
Collaborator

am still in favor of all steps rather than a subset. we never really print the steps, but it would be much clearer if the step number literally referred to the step number.

@macartan
Copy link
Collaborator Author

macartan commented Aug 22, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants