diff functions #404
Merged
diff functions #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfultz
reviewed
Feb 28, 2019
R/compare_designs.R
Outdated
| set.seed(seed) | ||
| design1 <- draw_data(design1) | ||
| set.seed(seed) | ||
| design2 <- draw_data(design2) |
There was a problem hiding this comment.
One cute thing would be if the ending .Random.seed was the same after two draws - if not, then you know the designs had different access patterns to the RNG.
nfultz
reviewed
Feb 28, 2019
R/compare_designs.R
Outdated
| #' @rdname compare_functions | ||
| #' @importFrom diffobj diffChr | ||
| #' @export | ||
| compare_design_summaries <- function(design1, design2, format = "ansi256", mode = "sidebyside", pager = "off", context = -1L) { |
There was a problem hiding this comment.
For this family of functions, parameterize by the comparison function:
compare_design_generic <- function(FUN, design1, design2, format = "ansi256", ...){
seed <- .Random.seed
x <- FUN(design1)
set.seed(seed)
y <- FUN(design2)
#etc
}
compare_design_summaries <- stackoverflow::partial(compare_design_generic, FUN=function(x) capture.output(summary(x)))
There was a problem hiding this comment.
You can also parameterize DIFF_FUN.
nfultz
reviewed
Feb 28, 2019
R/compare_designs.R
Outdated
| } | ||
|
|
||
| get_design_code <- function(design){ | ||
| sapply(design, function(x) clean_call(attributes(x)$call)) |
nfultz
reviewed
Feb 28, 2019
R/compare_designs.R
Outdated
| print.design_comparison <- function(x, ...) { | ||
| cat("Research design comparison\n\n") | ||
|
|
||
| print_console_header("Compare design code") |
There was a problem hiding this comment.
use a list, eg
labels = c("code_comparison"="design code", "data_comparison" = "draw_data(design)")
for(n in names(labels)) {
print_console_header(paste("Compare", labels[n))
print(x[[n]])
}
nfultz
reviewed
Feb 28, 2019
R/compare_designs.R
Outdated
|
|
||
| estimands_comparison <- compare_design_estimands(design1, design2, format = format, mode = mode, pager = pager, context = context) | ||
|
|
||
| estimates_comparison <- compare_design_estimates(design1, design2, format = format, mode = mode, pager = pager, context = context) |
There was a problem hiding this comment.
eek. Use a list to cut down on verbosity.
fns <- list(code_comparison=compare_design_code, data_comparison=compare_design_data, ...)
vals <- lappy(fns, function(f) f(design1, design2, format=format, mode=mode, pager=pager, context=context)
class(vals) <- "design_comparison"
vals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare_design_codewhich does diff of codecompare_design_estimateswhich runs draw_estimates(design) and then does a diff of the outputcompare_design_estimandswhich runs draw_estimands(design) and then does a diff of the outputcompare_design_datawhich runs draw_data(design) and then does a diff of the outputcompare_design_summarieswhich runs summary(design) and then does a diff of the outputand an omnibus function that runs them all one by one with section headers in between -
compare_designs