Skip to content

Commit

Permalink
Merge pull request #215 from DeclareDesign/fixing_deprecated_funs
Browse files Browse the repository at this point in the history
Fixes behavior of deprecated functions
  • Loading branch information
jaspercooper committed Dec 5, 2018
2 parents 5cbc8b4 + 6ffe840 commit 5205355
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ importFrom(rlang,eval_bare)
importFrom(rlang,expr)
importFrom(rlang,is_character)
importFrom(rlang,is_integerish)
importFrom(rlang,list2)
importFrom(rlang,parse_expr)
importFrom(rlang,quo_text)
importFrom(rlang,quos)
Expand Down
6 changes: 3 additions & 3 deletions R/binary_iv_designer.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#' @importFrom generics tidy
#' @importFrom estimatr iv_robust lm_robust
#' @importFrom stats runif
#' @importFrom rlang list2 expr eval_bare
#' @aliases simple_iv_designer
#' @export binary_iv_designer simple_iv_designer
#'
Expand Down Expand Up @@ -147,11 +148,10 @@ attr(binary_iv_designer, "description") <- "

simple_iv_designer <- function(...){
.Deprecated("binary_iv_designer")
binary_iv_designer(...)
dots <- list2(...)
eval_bare(expr(binary_iv_designer(!!!dots)))
}






12 changes: 7 additions & 5 deletions R/two_arm_designer.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#' @importFrom fabricatr fabricate
#' @importFrom randomizr conduct_ra
#' @importFrom stats rnorm
#' @importFrom rlang list2 expr eval_bare
#' @aliases simple_two_arm_designer
#' @export two_arm_designer simple_two_arm_designer
#'
Expand Down Expand Up @@ -67,12 +68,12 @@ two_arm_designer <- function(N = 100,
two_arm_design <- population + potential_outcomes + estimand + assignment + reveal_Y + estimator
}}}

attr(two_arm_design, "code") <-
construct_design_code(designer = two_arm_designer,
args = match.call.defaults(),
attr(two_arm_design, "code") <-
construct_design_code(designer = two_arm_designer,
args = match.call.defaults(),
exclude_args = "ate",
arguments_as_values = TRUE)

two_arm_design
}

Expand All @@ -90,7 +91,8 @@ attr(two_arm_designer, "description") <- "

simple_two_arm_designer <- function(...){
.Deprecated("two_arm_designer")
two_arm_designer(...)
dots <- list2(...)
eval_bare(expr(two_arm_designer(!!!dots)))
}


Expand Down
4 changes: 3 additions & 1 deletion R/two_by_two_designer.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#' @importFrom fabricatr fabricate
#' @importFrom randomizr conduct_ra
#' @importFrom estimatr lm_robust
#' @importFrom rlang list2 expr eval_bare
#' @export two_by_two_designer simple_factorial_designer
#'
#' @examples
Expand Down Expand Up @@ -156,5 +157,6 @@ attr(two_by_two_designer, "description") <- "

simple_factorial_designer <- function(...){
.Deprecated("two_by_two_designer")
two_by_two_designer(...)
dots <- list2(...)
eval_bare(expr(two_by_two_designer(!!!dots)))
}

0 comments on commit 5205355

Please sign in to comment.