Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review of function and documentation #170

Merged
merged 21 commits into from Aug 22, 2018
Merged

Review of function and documentation #170

merged 21 commits into from Aug 22, 2018

Conversation

clarabicalho
Copy link
Contributor

Key edits:

clarabicalho and others added 21 commits August 16, 2018 11:00
@clarabicalho
Correct cluster_sampling vignette
60353b1
@clarabicalho
Correct designer documentation
459ce77
@clarabicalho
Standardize cluster_sampling argument name
8ca8ea3
@clarabicalho
Add link to vignettes on website
18de96d 
Closes #167
update Rds
7673489
prob %in% (0,1)
e27d33d 
X'X is not invertible when all subjects are assigned to control or treatment
fix bug in arguments
062e6d9
Revert "fix bug in arguments"
75a0d58 
This reverts commit 062e6d9.
update argument name in all fields
a2cfbf8
update arg name in test
b409831
notes to 0
b5b9797
@clarabicalho
Add shiny arguments to simple_spillover_designer
04d987d
@clarabicalho
Add tests to designer arguments
bbd5cc1
@clarabicalho
Documentation typos
98f1a87
@clarabicalho
Take abs(bandwidth) in regression_discontinuity_designer()
47d656f
@clarabicalho
Broken shiny description
78928c9
@clarabicalho
Typo regression_discontinuity_designer()
0f4da31
@clarabicalho
Add blocks to cluster_sampling_designer()
276d859 
Closes #166
@clarabicalho
Include additional tests
ff4207d 
Gets to 100% coverage
@clarabicalho
Build updates
b5adffe
@clarabicalho
Shorten estimand names in multi_arm_designer()
6345631 
Closes #154
jaspercooper
jaspercooper approved these changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@jaspercooper jaspercooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jaspercooper jaspercooper merged commit 0227637 into master Aug 22, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 825

  • 26 of 26 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 805: 0.0%
Covered Lines: 520
Relevant Lines: 520
💛 - Coveralls

@jaspercooper jaspercooper deleted the pre_v0.1.1_review branch August 22, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaspercooper jaspercooper jaspercooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clarabicalho @coveralls @jaspercooper