Wizard updates #224
Merged
Wizard updates #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfultz
reviewed
Feb 8, 2019
| @@ -9,6 +9,7 @@ for(designer in designers){ | |||
|
|
|||
| the_designer <- get(x = designer) | |||
| has_shiny <- !is.null(attributes(the_designer)$shiny_arguments) | |||
| has_definition <- !is.null(attributes(the_designer)$definitions) | |||
There was a problem hiding this comment.
you might want to write helper methods for getting / setting definitions on objects.
There was a problem hiding this comment.
Could we add those methods instead on the DDWizard side? I don't see users needing to access these definitions in DesignLibrary, oder? @jaspercooper
There was a problem hiding this comment.
that makes sense to me
|
happy for @nfultz to merge this once you and @clabima have resolved the above. Thanks both! |
Pull Request Test Coverage Report for Build 1275
💛 - Coveralls |
|
@clabima let me know when I can update from master and merge this |
|
@jaspercooper all clear on my side unless @nfultz objects. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates needed for DDWizard deployment. Mainly: