Merge pull request #408 from DeclareDesign/cran-patch-jan-24

Cran patch jan 24 - v 1.0.2
DeclareDesign · Mar 30, 2024 · 521a331 · 521a331
2 parents d0c76dc + ec42eca
commit 521a331
Show file tree

Hide file tree

Showing 12 changed files with 51 additions and 16 deletions.
diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION
@@ -0,0 +1,3 @@
+Version: 1.0.2
+Date: 2024-01-17 06:28:29 UTC
+SHA: 70b42698119d523bbacc9294c9238b7014715e7a
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: estimatr
 Type: Package
 Title: Fast Estimators for Design-Based Inference
-Version: 1.0.0
+Version: 1.0.2
 Authors@R: c(person("Graeme", "Blair", email = "graeme.blair@gmail.com", role = c("aut", "cre")),
              person("Jasper", "Cooper", email = "jjc2247@columbia.edu", role = c("aut")),
              person("Alexander", "Coppock", email = "alex.coppock@yale.edu", role = c("aut")),
@@ -14,7 +14,7 @@ Description: Fast procedures for small set of commonly-used, design-appropriate
 URL: https://declaredesign.org/r/estimatr/, https://github.com/DeclareDesign/estimatr
 BugReports: https://github.com/DeclareDesign/estimatr/issues
 License: MIT + file LICENSE
-Depends: R (>= 3.5.0)
+Depends: R (>= 3.6.0)
 Imports:
     Formula,
     generics,
@@ -23,7 +23,7 @@ Imports:
     rlang (>= 0.2.0)
 LinkingTo: Rcpp, RcppEigen
 Encoding: UTF-8
-RoxygenNote: 7.2.0
+RoxygenNote: 7.2.3
 LazyData: true
 Suggests:
     fabricatr (>= 0.10.0),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# estimatr 1.0.2
+
+* Minor documentation changes to stay current on CRAN.
+
 # estimatr 1.0.0
 
 * Version bump to coincide with DeclareDesign package version 1.0.0

diff --git a/R/estimatr.R b/R/estimatr.R
@@ -15,4 +15,4 @@
 #' @importFrom Formula as.Formula
 #' @importFrom rlang enquos enquo eval_tidy quo_get_expr quo_set_expr quo_is_missing sym quo
 #' @name estimatr
-NULL
+"_PACKAGE"
diff --git a/R/estimatr_horvitz_thompson.R b/R/estimatr_horvitz_thompson.R
@@ -138,7 +138,7 @@
 #' @seealso \code{\link[randomizr]{declare_ra}}
 #'
 #' @references
-#' Aronow, Peter M, and Joel A Middleton. 2013. "A Class of Unbiased Estimators of the Average Treatment Effect in Randomized Experiments." Journal of Causal Inference 1 (1): 135-54. \url{http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.712.5830&rep=rep1&type=pdf}.
+#' Aronow, Peter M, and Joel A Middleton. 2013. "A Class of Unbiased Estimators of the Average Treatment Effect in Randomized Experiments." Journal of Causal Inference 1 (1): 135-54. \doi{10.1515/jci-2012-0009}.
 #'
 #' Aronow, Peter M, and Cyrus Samii. 2017. "Estimating Average Causal Effects Under Interference Between Units." Annals of Applied Statistics, forthcoming. \url{https://arxiv.org/abs/1305.6156v3}.
 #'

diff --git a/R/estimatr_lm_lin.R b/R/estimatr_lm_lin.R
@@ -84,11 +84,12 @@
 #'   \item{call}{the original function call}
 #'   \item{fitted.values}{the matrix of predicted means}
 #' We also return \code{terms} and \code{contrasts}, used by \code{predict},
-#' and \code{scaled_center}{the means of each of the covariates used for centering them}
+#' and \code{scaled_center} (the means of each of the covariates used for centering them).
 #'
 #' @seealso \code{\link{lm_robust}}
 #'
-#' #' @references
+#' @references
+#'
 #' Freedman, David A. 2008. "On Regression Adjustments in Experiments with Several Treatments." The Annals of Applied Statistics. JSTOR, 176-96. \doi{10.1214/07-AOAS143}.
 #'
 #' Lin, Winston. 2013. "Agnostic Notes on Regression Adjustments to Experimental Data: Reexamining Freedman's Critique." The Annals of Applied Statistics 7 (1). Institute of Mathematical Statistics: 295-318. \doi{10.1214/12-AOAS583}.

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,6 +1,6 @@
 ## Submission
 
-Thank you for reviewing this minor patch, which addresses failures on CRAN due to ivpack being archived. The version is also bumped and the email address of the maintainer changed.
+Small changes to update based on Kurt's 8/19/23 email and also address C++ warning in R CMD CHECK.
 
 There are no changes to worse in reverse depends. 
 

diff --git a/man/estimatr.Rd b/man/estimatr.Rd
diff --git a/man/horvitz_thompson.Rd b/man/horvitz_thompson.Rd
diff --git a/man/lm_lin.Rd b/man/lm_lin.Rd
diff --git a/src/Makevars b/src/Makevars
@@ -1,2 +1 @@
-CXX_STD = CXX11
 PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)
diff --git a/src/Makevars.win b/src/Makevars.win
@@ -1,3 +1,2 @@
 
-CXX_STD = CXX11
 PKG_LIBS = $(LAPACK_LIBS) $(BLAS_LIBS) $(FLIBS)