Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lh_robust bug #320

Open
graemeblair opened this issue Sep 5, 2019 · 6 comments
Open

lh_robust bug #320

graemeblair opened this issue Sep 5, 2019 · 6 comments

Comments

@graemeblair
Copy link
Member

From a user:

Since version 0.18.0 (or earlier), I found that the joint hypothesis test is not performed with lh_robust, but it only performs single hypotheses.

In the manual (pp. 24, "Example"), it writes*

# The linear hypothesis argument can be specified equivalently as: 
lh_robust(y ~ x + z, data = dat, linear_hypothesis = "z = 2x") 
lh_robust(y ~ x + z, data = dat, linear_hypothesis = c("z = 1", "x = 2")) 

but actually they perform different hypothesis tests. The former is the test of z = 2x, but the latter only performs the t-test of z = 1 and x = 2, respectively, but not the joint test of z = 1 AND x = 2. 

In the car::linearHypothesis function, the same specification performs the joint test and returns the result of F-test. 
 
I think that lh_robust used to returns the same result as linearHypothesis. (probably version 0.16.0)
@graemeblair
Copy link
Member Author

This is not a bug. What should happen here is glance(lh_robust(.)) should report the F test. Switching to a feature request.

@lukesonnet
Copy link
Contributor

So the idea is to have glance report joint specification f tests when we are glancing a lh_robust object?

@graemeblair
Copy link
Member Author

Exactly

@lukesonnet
Copy link
Contributor

lukesonnet commented Sep 6, 2019

But these are different tests? I'm not sure how these are testing the same thing. I think our help is wrong. We can still add this feature to glance, but the example isn't true, right?

@graemeblair
Copy link
Member Author

Exactly, we should just add to glance but not based on the example

@lukesonnet
Copy link
Contributor

Argh we should have removed this example before 0.20.0. They aren't the same.

lukesonnet added a commit that referenced this issue Sep 12, 2019
@lukesonnet lukesonnet added this to the Bugfixes/docs for 0.22.0 milestone Sep 12, 2019
lukesonnet added a commit that referenced this issue Feb 5, 2020
@lukesonnet lukesonnet removed this from the Bugfixes/docs for 0.22.0 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants