Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding skips for tests relying on suggested packages #402

Open
michaelquinn32 opened this issue Dec 6, 2022 · 1 comment · May be fixed by #410
Open

Consider adding skips for tests relying on suggested packages #402

michaelquinn32 opened this issue Dec 6, 2022 · 1 comment · May be fixed by #410
Milestone
summer 2023

Comments

@michaelquinn32
Copy link

Hi!

I hope this finds you well.

Several tests rely on randomizr, a suggested package. For cases where this package might not be installed, it would be nice if these tests cases were skipped. Testthat has a tool for this: skip_if_not_installed().

Would you be interested in a PR?

Thanks!
@nfultz
Copy link
Contributor

nfultz commented Dec 6, 2022

We would most def welcome a PR, although I am not sure if there are plans to cut a new release this school year. @acoppock ?

@graemeblair graemeblair added this to the summer 2023 milestone May 25, 2023
@MichaelChirico MichaelChirico linked a pull request Jun 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
summer 2023
Development

Successfully merging a pull request may close this issue.

Optionally skip tests requiring Suggests dependencies MichaelChirico/estimatr
3 participants
@nfultz @graemeblair @michaelquinn32