Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving some code around #17

Merged
merged 7 commits into from
Oct 24, 2017
Merged

Moving some code around #17

merged 7 commits into from
Oct 24, 2017

Conversation

nfultz
Copy link
Contributor

@nfultz nfultz commented Oct 20, 2017

  • Pull out fab inner loop
  • Pull out vararg checking
  • pull out ID generation

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.786% when pulling 32470af on nfultz/refactor_fabricate2 into 63d5a37 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.786% when pulling 32470af on nfultz/refactor_fabricate2 into 63d5a37 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 91.016% when pulling e001b63 on nfultz/refactor_fabricate2 into 63d5a37 on master.

@coveralls
Copy link

coveralls commented Oct 21, 2017

Coverage Status

Coverage decreased (-1.5%) to 90.535% when pulling d4ea9c0 on nfultz/refactor_fabricate2 into 63d5a37 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 90.65% when pulling 151a9a9 on nfultz/refactor_fabricate2 into 63d5a37 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.4%) to 90.65% when pulling 151a9a9 on nfultz/refactor_fabricate2 into 63d5a37 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.763% when pulling ed14837 on nfultz/refactor_fabricate2 into 63d5a37 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.763% when pulling ed14837 on nfultz/refactor_fabricate2 into 63d5a37 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.763% when pulling cc91b2a on nfultz/refactor_fabricate2 into 63d5a37 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.763% when pulling cc91b2a on nfultz/refactor_fabricate2 into 63d5a37 on master.

@aaronrudkin aaronrudkin merged commit 18dd32d into master Oct 24, 2017
@aaronrudkin aaronrudkin deleted the nfultz/refactor_fabricate2 branch October 24, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants