Address performance bottlenecks #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| else: | ||
|
|
||
| logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(message)s', datefmt='%d-%b-%y %H:%M:%S') | ||
| async def on_response_chunk_received(session, trace_config_ctx, params): |
| tree = LinkTree(node, stop_depth=args.depth) | ||
| else: | ||
|
|
||
| logging.basicConfig(level=logging.DEBUG, format='%(asctime)s - %(message)s', datefmt='%d-%b-%y %H:%M:%S') |
| page = LinkIO.read('https://check.torproject.org/', show_msg=True) | ||
| page = BeautifulSoup(page, 'html.parser') | ||
| ip_cont = page.find('strong') | ||
| link = await LinkIO.read('https://check.torproject.org/', show_msg=True, session=session) |
| node = LinkNode(link, session) | ||
| title = await node.name | ||
| link_status = await node.status | ||
| except Exception as err: |
There was a problem hiding this comment.
local variable 'err' is assigned to but never used
| show_msg=False, | ||
| headers=None, | ||
| schemes=None, | ||
| session=None): |
There was a problem hiding this comment.
continuation line under-indented for visual indent
continuation line with same indent as next logical line
|
|
||
| @property | ||
| async def status(self): | ||
| doc = await self.getDocument() |
There was a problem hiding this comment.
local variable 'doc' is assigned to but never used
| self._document = BeautifulSoup(await response.text('ISO-8859-1'), 'html.parser') | ||
| if get_response: | ||
| return self._document, response | ||
| return self._document |
There was a problem hiding this comment.
indentation is not a multiple of four
| response = await self._session.get(self.uri, compress=True) | ||
| self._document = BeautifulSoup(await response.text('ISO-8859-1'), 'html.parser') | ||
| if get_response: | ||
| return self._document, response |
There was a problem hiding this comment.
indentation is not a multiple of four
| if not self._document: | ||
| response = await self._session.get(self.uri, compress=True) | ||
| self._document = BeautifulSoup(await response.text('ISO-8859-1'), 'html.parser') | ||
| if get_response: |
There was a problem hiding this comment.
indentation is not a multiple of four
| async def getDocument(self, get_response=False): | ||
| if not self._document: | ||
| response = await self._session.get(self.uri, compress=True) | ||
| self._document = BeautifulSoup(await response.text('ISO-8859-1'), 'html.parser') |
KingAkeem
commented
Oct 13, 2019
modules/display_status.py
Outdated
| @@ -0,0 +1,27 @@ | |||
| from ctypes import * | |||
There was a problem hiding this comment.
I want to move this file back to the submodule.
| self._uri = link | ||
|
|
||
| async def getDocument(self, get_response=False): | ||
| if not self._document: |
There was a problem hiding this comment.
indentation is not a multiple of four
|
|
||
| class LinkNode: | ||
| """Represents link node in a link tree.""" | ||
| DEFAULT_NAME = 'TITLE NOT FOUND' | ||
| DEFAULT_STATUS = lambda uri: color(uri, 'yellow') |
There was a problem hiding this comment.
do not assign a lambda expression, use a def
| doc, response = await node.getDocument(True) | ||
| return response.headers | ||
|
|
||
| async def get_children(node): |
|
|
||
| def get_metadata(node): | ||
| async def get_status(node): |
| link = child.get('src') | ||
| if link and LinkNode.valid_link(link): | ||
| links.append(link) | ||
| return links | ||
|
|
||
| async def get_name(node): |
|
|
||
| def get_emails(node): | ||
| async def get_emails(node): |
|
Dropped effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
Changes Proposed
requeststoaiohttpto introduce asynchronous networking.