Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile #321

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Added Dockerfile #321

merged 4 commits into from
Oct 18, 2023

Conversation

SasikaSankalana
Copy link
Contributor

Issue #319

Explanation of Changes

Added the Dockerfile to build and run the container.

Screenshots of new feature/change

Copy link
Member

@KingAkeem KingAkeem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename file to Dockerfile so that it can be detected by docker.

This works when using --disable-socks5 but I'm getting a connection refused when trying to use the socks5 proxy. Maybe try exposing the host as well?

Besides that, everything else is looking good so far. Looking forward to the finished product.

@SasikaSankalana
Copy link
Contributor Author

@KingAkeem Have you tried running the container using this command.

docker run --network="host" your-image-name poetry run python torbot -u https://www.example.com --depth 2 --visualize tree --save json

@KingAkeem
Copy link
Member

Awesome, that worked perfectly. Could you please rename the file to Dockerfile (lower case f)? If you feel comfortable updating the README, then you can add the examples there so it's apparent. Otherwise I'll take care of it.

Once the file is renamed, this is good to go. Great work and thank you for your contribution.

@SasikaSankalana
Copy link
Contributor Author

@KingAkeem Renamed the Dockerfile. I think it's better to change the README by yourself.

@KingAkeem KingAkeem merged commit 82d5c0a into DedSecInside:dev Oct 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants