Merge pull request #99 from Dedac/Rest-Calls-With-non-strings

Add more field types to URL support Resolves #98

azure-devops-extension-dev.json

@@ -1,6 +1,6 @@
 {
     "id":"RestDataMappingPicklistDev",
-    "version": "0.3.7",
+    "version": "0.4.0",
     "baseUri": "https://localhost:44300",
     "public": false,
     "private":true

azure-devops-extension.json

@@ -2,7 +2,7 @@
     "manifestVersion": 1.0,
     "id": "RestDataMappingPicklist",
     "publisher": "dedac",
-    "version": "0.3.7",
+    "version": "0.4.0",
     "name": "Rest Data Mapping Picklist",
     "description": "Load work item values from a specified REST endpoint and map additional REST data to your work item",
     "public": true,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "rest-data-mapping-picklist",
-  "version": "0.3.7",
+  "version": "0.4.0",
   "description": "An Azure DevOps Work Item Control for loading values from a Rest endpoint",
   "main": "index.js",
   "repository": {

src/RestServiceData.ts

@@ -17,9 +17,9 @@ export class RestServiceData {
     }
     const keyFieldName = SDK.getConfiguration().witInputs.RestServiceKeyField;
     const arrayPath = SDK.getConfiguration().witInputs.PathToArray;
-
-    var arrayData = get(resp.data, arrayPath, resp.data);
-
+    if (resp !== undefined && resp.data !== undefined) {
+      var arrayData = get(resp.data, arrayPath, resp.data);
+    }
     if (arrayData) {
       if (arrayData.constructor !== Array) {
         console.dir(arrayData);

src/parameter-replacement.ts

@@ -10,8 +10,15 @@ export async function ReplaceFieldParameters(hasFields:string) : Promise<string>
         var replaceMe = hasFields.substring(index, endIndex + 1);
         var fieldName = replaceMe.replace('$(', '').replace(')', '').trim();
         var value = await service.getFieldValue(fieldName, { returnOriginalValue: false });
-        if (typeof value === "string") {        
-            hasFields = hasFields.replace(replaceMe, value);
+        if (!!value && !!value.toString()) {
+            var escapedValue = JSON.stringify(value);
+            // remove outer quotes from the escaped value if they exist
+            // this assumes the user has added quotes of their own in the configuration
+            if (escapedValue.startsWith('"') && escapedValue.endsWith('"')) {
+                escapedValue = escapedValue.substring(1, escapedValue.length - 1);
+            }
+
+            hasFields = hasFields.replace(replaceMe, escapedValue);
         } else  {
             hasFields = hasFields.replace(replaceMe, "");
         }