Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #57 and probably #51 #60

Merged
merged 13 commits into from
Mar 26, 2018
Merged

Fix issue #57 and probably #51 #60

merged 13 commits into from
Mar 26, 2018

Conversation

francoisthire
Copy link
Collaborator

Replace a min by a max.

@francoisthire
Copy link
Collaborator Author

Finally, we have a new restriction where a free variable on the left should be applied to the same number of argument. However, this PR is not ready to be merged, since @Gaspi will clean the code.

kernel/rule.ml Outdated

More precisely:
- Context variables are exclusively applied to distinct locally bound variables
- Occurences of such variable are all applied to the same number of arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Occurences of each context variable" instead of "Occurences of such variable".

@francoisthire
Copy link
Collaborator Author

@Gaspi I think this PR is ready to be merged.

Copy link
Contributor

@GuillaumeGen GuillaumeGen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's time to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants