Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos docstring of get_batch_indices #31

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix typos docstring of get_batch_indices #31

merged 1 commit into from
Sep 14, 2021

Conversation

martinp7
Copy link
Collaborator

@martinp7 martinp7 commented Sep 14, 2021 •
edited
Loading

Closes #29

  • Fixed the example provided in the docstring
  • Removed the args listed in Args section but not available in the signature
  • Remove the typing in docstring since it is redundant with the static typing (as suggested in CONTRIBUTING.md file)

@martinp7 martinp7 mentioned this pull request Sep 14, 2021
Open
@delfosseaurelien delfosseaurelien merged commit 5efa4e7 into main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delfosseaurelien delfosseaurelien delfosseaurelien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in docstring of get_batch_indices defined in biotransformers/lightning_utils/data.py
2 participants
@martinp7 @delfosseaurelien