Do not require mocks for ARRAY JOIN clause arguments #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somtom
approved these changes
Mar 27, 2024
The `ARRAY JOIN` clause in Clickhouse is currently recognised as a table that requires a mock by the library. This is not the case as this clause is used for expanding arrays in the source table into separate rows. This commit adds an additional clause to the `get_source_tables` helper function to ignore joins of kind `ARRAY`. Closes #48
smoothml
force-pushed
the
clickhouse-array-join
branch
from
d3c12f2
to
c98648f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ARRAY JOINclause in Clickhouse is currently recognised as a table that requires a mock by the library. This is not the case as this clause is used for expanding arrays in the source table into separate rows. This commit adds an additional clause to theget_source_tableshelper function to ignore joins of kindARRAY.Closes #48