Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zq/Update masked select by aclnn with expand #1263

Merged
merged 12 commits into from
Jun 24, 2024
Merged

zq/Update masked select by aclnn with expand #1263

merged 12 commits into from
Jun 24, 2024

Conversation

NeosZhang
Copy link
Collaborator

Motivation and Context

Update masked select by aclnn with expand

Description

Update masked select by aclnn with expand

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

yangbofun
yangbofun reviewed Jun 24, 2024
View reviewed changes
impl/ascend/functions/masked_select.cpp Outdated
int64_t* viewDims = nullptr;
uint64_t viewDimNum = 0;
using aclGetViewShapeFunc = int (*)(const aclTensor* tensor, int64_t** viewDims, uint64_t* viewDimsNum);
aclGetViewShapeFunc aclGetViewShape = reinterpret_cast<aclGetViewShapeFunc>(impl::ascend::aclnn_adaptor::getOpApiFuncAddr("aclGetViewShape"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加static关键字，保证只调用一次。

@yangbofun yangbofun merged commit 7052517 into DeepLink-org:feat/replace_opplugin_by_aclnn Jun 24, 2024
14 of 15 checks passed
@yangbofun yangbofun deleted the update_maskedSelect_by_aclnn_2nd branch June 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangbofun yangbofun yangbofun approved these changes

@hellozmz hellozmz Awaiting requested review from hellozmz hellozmz is a code owner

@zhangzefeng92 zhangzefeng92 Awaiting requested review from zhangzefeng92 zhangzefeng92 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeosZhang @yangbofun