Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DIOPI] Wx/align standard flash attention interface definition #1268

Conversation

POI-WX
Copy link
Contributor

@POI-WX POI-WX commented Jun 19, 2024

Motivation and Context

  • Align standard flash attention interface definition.
  • Add implementation of diopiFlashAttention and diopiFlashAttentionVarLen for camb.
  • Add implementation of diopiCustomizedFlashAttention and diopiCustomizedFlashAttentionVarLen for ascend.

Description

Use cases (Optional)

BC-breaking (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the Contributors.md to create this PR.
  • Pre-commit or linting tools indicated in Contributors.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@POI-WX POI-WX requested a review from yangbofun as a code owner June 19, 2024 05:33
@yangbofun yangbofun merged commit c925d2f into DeepLink-org:main Jun 27, 2024
13 of 16 checks passed
@yangbofun yangbofun deleted the wx/align_standard_flash_attention_interface_definition branch June 27, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants