Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Update to read decoy-specific pssm files #107

Merged
merged 9 commits into from
Oct 23, 2019
Merged

Conversation

CunliangGeng
Copy link
Member

To solve issue #105.

If both reference pssm files and decoy-specific pssm files exist, use the decoy-specific ones for the decoy; otherwise use the reference pssm files.

Note: please first merge RP #103 and then this RP.

@coveralls
Copy link

coveralls commented Oct 8, 2019

Pull Request Test Coverage Report for Build 583

  • 5 of 11 (45.45%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 74.84%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank/features/FeatureClass.py 2 3 66.67%
deeprank/tools/pdb2sql.py 0 1 0.0%
deeprank/features/FullPSSM.py 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
deeprank/features/FullPSSM.py 1 73.85%
Totals Coverage Status
Change from base Build 571: -0.03%
Covered Lines: 2228
Relevant Lines: 2977

💛 - Coveralls

Copy link
Member

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should add test for both cases

@CunliangGeng CunliangGeng merged commit 5d855ea into development Oct 23, 2019
@CunliangGeng CunliangGeng deleted the issue105_pssm branch October 23, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants