Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Guideline and workflow for internal developers #149

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

CunliangGeng
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 10, 2020

Pull Request Test Coverage Report for Build 789

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 158 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.2%) to 76.613%

Files with Coverage Reduction New Missed Lines %
deeprank/features/BSA.py 5 77.63%
deeprank/features/FeatureClass.py 7 87.72%
deeprank/features/ResidueDensity.py 8 81.18%
deeprank/features/FullPSSM.py 13 74.02%
deeprank/generate/GridTools.py 50 70.76%
deeprank/generate/DataGenerator.py 75 69.63%
Totals Coverage Status
Change from base Build 762: 0.2%
Covered Lines: 1579
Relevant Lines: 2061

💛 - Coveralls

Copy link
Contributor

@LilySnow LilySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice instruction. For our developers, we should use git clone instead of conda or pip, right? It is not clear from this instruction.

@CunliangGeng
Copy link
Member Author

@LilySnow you might be confused with git clone, pip and conda.
git clone is to copy the Github online repo to your local machine, and then you can do changes of code in the local repo.
pip and conda are just tools to help install python packages. For DeepRank, we only release it for pypi but not conda, so we must make sure pip work well to install dependencies. But you could use conda during developing.

Copy link
Member

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix the few comments it's all good for me ! Thanks

developer_guideline.md Outdated Show resolved Hide resolved
developer_guideline.md Outdated Show resolved Hide resolved
@CunliangGeng CunliangGeng merged commit 1c02ecb into development Jun 2, 2020
@CunliangGeng CunliangGeng deleted the developer_workflow branch June 2, 2020 07:08
@CunliangGeng CunliangGeng restored the developer_workflow branch June 2, 2020 07:09
@CunliangGeng CunliangGeng deleted the developer_workflow branch January 20, 2021 14:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants