-
Notifications
You must be signed in to change notification settings - Fork 27
add an operating function to find the surrounding atoms around a residue #223
Conversation
Pull Request Test Coverage Report for Build 722769742
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Coos. The codes are quite neat.
I have minor questions that I have added as comments in the scripts.
deeprank/operate/pdb.py
Outdated
|
||
residue_position = numpy.array([residue_x, residue_y, residue_z]) | ||
|
||
if get_squared_distance(atom_position, residue_position) < squared_max_interatomic_distance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we taking all atoms into account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might say we are: all atoms that pdb2sql reads from the pdb file are listed and compared to all atoms in the mutant residue. Does this answer your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ok. I thought we would only look at C-alpha.
So the code looks at all atoms within 8.5 angstrom distance of every other atom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd have to insert the 8.5 angstrom as the argument "max_interatomic_distance". I put this in the comments.
The function "get_residue_contact_atom_pairs" is intended to be used in the efro project, to get the atoms that surround a residue within a given distance.