Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

add an operating function to find the surrounding atoms around a residue #223

Merged
merged 8 commits into from
Apr 6, 2021

Conversation

cbaakman
Copy link
Collaborator

@cbaakman cbaakman commented Apr 1, 2021

The function "get_residue_contact_atom_pairs" is intended to be used in the efro project, to get the atoms that surround a residue within a given distance.

@cbaakman cbaakman requested a review from rgayatri April 1, 2021 12:17
@coveralls
Copy link

coveralls commented Apr 1, 2021

Pull Request Test Coverage Report for Build 722769742

  • 128 of 133 (96.24%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 78.502%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank/models/atom.py 14 15 93.33%
deeprank/operate/pdb.py 32 33 96.97%
deeprank/models/residue.py 13 16 81.25%
Totals Coverage Status
Change from base Build 704318444: 1.1%
Covered Lines: 1782
Relevant Lines: 2270

💛 - Coveralls

Copy link

@rgayatri rgayatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Coos. The codes are quite neat.
I have minor questions that I have added as comments in the scripts.


residue_position = numpy.array([residue_x, residue_y, residue_z])

if get_squared_distance(atom_position, residue_position) < squared_max_interatomic_distance:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we taking all atoms into account?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might say we are: all atoms that pdb2sql reads from the pdb file are listed and compared to all atoms in the mutant residue. Does this answer your question?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ok. I thought we would only look at C-alpha.
So the code looks at all atoms within 8.5 angstrom distance of every other atom?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to insert the 8.5 angstrom as the argument "max_interatomic_distance". I put this in the comments.

test/operate/test_pdb.py Show resolved Hide resolved
deeprank/operate/pdb.py Outdated Show resolved Hide resolved
deeprank/operate/pdb.py Outdated Show resolved Hide resolved
@rgayatri rgayatri merged commit e8c0511 into efro-project Apr 6, 2021
@cbaakman cbaakman deleted the mutant-contacts branch April 6, 2021 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants