This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
Update DataSet.py #237
Closed
Update DataSet.py #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug compute get_grid_shape only if grid_shape is not provided
Pull Request Test Coverage Report for Build 984135998
💛 - Coveralls |
CunliangGeng
reviewed
Aug 3, 2021
| # get grid shape | ||
| self.get_grid_shape() | ||
|
|
||
| if self.grid_shape is None: |
There was a problem hiding this comment.
The if self.grid_shape is None condition has been considered in the function get_grid_shape, see the line 824 of the same file.
There was a problem hiding this comment.
Indeed but then the following elif condition is not correctly placed (line 839). It is more logical to remove the if self.grid_shape is None from that function and to enter the get_grid_shape function only if self.grid_shape does not exist.
This same issue is pointed out in #242
There was a problem hiding this comment.
Thanks, I'll close this PR then.
CunliangGeng
reviewed
Aug 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug
compute get_grid_shape only if grid_shape is not provided