Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

fix: deprecated numpy datatypes #254

Merged
merged 3 commits into from
Feb 13, 2023
Merged

fix: deprecated numpy datatypes #254

merged 3 commits into from
Feb 13, 2023

Conversation

DaniBodor
Copy link
Contributor

@DaniBodor DaniBodor commented Jan 24, 2023

updated deprecated numpy dtypes.
Feel free to merge if you agree with the changes

@DaniBodor
Copy link
Contributor Author

@DarioMarzella , @LilySnow, would one of you like to check this?
You can go ahead and merge if you're ok with it.

@coveralls
Copy link

coveralls commented Feb 3, 2023

Pull Request Test Coverage Report for Build 4083062783

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0%) to 77.12%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank/features/FullPSSM.py 2 3 66.67%
Totals Coverage Status
Change from base Build 1806896761: -0.0%
Covered Lines: 1628
Relevant Lines: 2111

💛 - Coveralls

@DaniBodor DaniBodor changed the title np.float32 instead of np.float fix: deprecated numpy datatypes Feb 3, 2023
@DaniBodor
Copy link
Contributor Author

I have changed the settings for coveralls to only give a fail if the coverage decreases by at least 0.5%. I can't find a way to rerun that test to show that it now doesn't fail anymore without randomly changing something in the code so that it automatically reruns all tests, which seems a bit unnecessary.

@DaniBodor DaniBodor merged commit 3d36229 into master Feb 13, 2023
@DaniBodor DaniBodor deleted the numpy_floats_dbodor branch February 13, 2023 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants