Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

fix the GLY PSSM issue and added a no_ condition to pdb2sql #60

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

NicoRenaud
Copy link
Member

I've fixed the GLY issue I think
I've also added a 'no_' condition to pdb2sql but we don't need it in the end.
If the test passes (they should) can you check and merge ?

@coveralls
Copy link

coveralls commented Mar 14, 2019

Pull Request Test Coverage Report for Build 394

  • 17 of 20 (85.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 73.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank/tools/pdb2sql.py 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
deeprank/features/PSSM_IC.py 1 75.73%
deeprank/features/FullPSSM.py 1 78.9%
Totals Coverage Status
Change from base Build 390: -0.03%
Covered Lines: 2096
Relevant Lines: 2851

💛 - Coveralls

@CunliangGeng
Copy link
Member

Test passed and interface GLYs were present for all features, great! So green light for merging the code :-)

@LilySnow LilySnow merged commit 112c7c5 into development Mar 15, 2019
@LilySnow
Copy link
Contributor

Thanks. Merge done. I closed the issue.

@CunliangGeng CunliangGeng deleted the fix_gly_pssm branch February 18, 2020 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants