-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
LilySnow
commented
Jul 16, 2019
- plot_utils.py: for plotting success rate and hit rate averaging over cases. compare with haddock scores.
- run_slurmFLs.py: submit slurm jobs by batches (one batch waiting for the first N batches to finish). Each job uses M cores in parallel.
- get_h5subset.py: extract a subset of docked models from one hdf5 to form a small test set.
Pull Request Test Coverage Report for Build 509
💛 - Coveralls |
…to successrate Trying to tidy up my code (security issue from subprocess) locally.
Tried to use |
…to successrate added unitest for hitrate and success rate in plot_utils.py
split plot_utils to calcualtion and plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the utility codes are only used by ourselves on very specific tasks, e.g. comparison with Haddock. And thus these code are much less interesting and useful to general users. I suggest we create an independent repo for them.
deeprank/utils/count_hits.py
Outdated
@@ -0,0 +1,32 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will replace count_hits.py
with my code for checking statistics including hits, which is more general.
@@ -0,0 +1,31 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be updated to be able to extract not only 5 but first N models.
deeprank/utils/get_subset.py
Outdated
@@ -0,0 +1,31 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be deleted. It is same as get_h5subset.py
.
test/test_hitrate_successrate.py
Outdated
@@ -0,0 +1,64 @@ | |||
import unittest | |||
from deeprank.utils.plot_utils import evaluate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed due to the R_HOME
problem from rpy2
package, but the tests passed locally. Could move the utility code to a new repo for only in-house using, considering these code are non-generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rpy2 is not needed in unittest. Too many repos already ... At the current stage, we are the major users of deeprank.
@@ -0,0 +1,169 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract the calculation of hit/success rate from plot_utils to this new file, which could avoid CI failure due to the import of rpy2
module.