Skip to content
This repository has been archived by the owner on Nov 28, 2023. It is now read-only.

Updates of learn on logging, warnings and exceptions #98

Merged
merged 8 commits into from
Sep 17, 2019

Conversation

CunliangGeng
Copy link
Member

Similar to #97, updating loggings, warnings and exceptions on learn code.

@coveralls
Copy link

coveralls commented Sep 11, 2019

Pull Request Test Coverage Report for Build 549

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 74.628%

Changes Missing Coverage Covered Lines Changed/Added Lines %
deeprank/generate/DataGenerator.py 3 4 75.0%
Totals Coverage Status
Change from base Build 546: 0.009%
Covered Lines: 2209
Relevant Lines: 2960

💛 - Coveralls

Copy link
Member

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the logging part is really nice and much better than just dumping that to screen.
The changes on the dataset and NeuralNet are too big for me to precisely check everything.
But I trust you there !

@NicoRenaud NicoRenaud merged commit 5bc7968 into development Sep 17, 2019
@NicoRenaud NicoRenaud deleted the log_learn branch September 17, 2019 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants