Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify GridSettings arguments to accept different directions' resolutions #280

Closed
2 tasks done
gcroci2 opened this issue Dec 13, 2022 · 2 comments · Fixed by #292
Closed
2 tasks done

Modify GridSettings arguments to accept different directions' resolutions #280

gcroci2 opened this issue Dec 13, 2022 · 2 comments · Fixed by #292
Labels
stale issue not touched from too much time
Projects
Generalization - Task 2

Comments

@gcroci2
Copy link
Collaborator

gcroci2 commented Dec 13, 2022 •
edited

Right now, GridSettings class accepts points_count and size only as single values (int and float, respectively).

  • Add the possibility to insert a different number of points and different sizes in each of the three grid directions x, y and z.
  • Add two proper tests for both cases.
@gcroci2 gcroci2 created this issue from a note in Generalization - Task 2 (To Do) Dec 13, 2022
@gcroci2 gcroci2 added priority Solve this first and removed priority Solve this first labels Dec 13, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale issue not touched from too much time label Jan 13, 2023
@gcroci2 gcroci2 removed the stale issue not touched from too much time label Jan 13, 2023
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale issue not touched from too much time label Feb 15, 2023
@gcroci2 gcroci2 linked a pull request Mar 3, 2023 that will close this issue
feat: add the option to have a grid box of different x,y and z dimensions #292
Merged
@gcroci2 gcroci2 closed this as completed Mar 3, 2023
Generalization - Task 2 automation moved this from To Do to Done Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale issue not touched from too much time
Projects
No open projects
Generalization - Task 2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add the option to have a grid box of different x,y and z dimensions DeepRank/deeprank2
1 participant
@gcroci2