Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to have different x, y and z dimensions for the grid box. #290

Closed
cbaakman opened this issue Dec 14, 2022 · 0 comments · Fixed by #292
Closed

Add the option to have different x, y and z dimensions for the grid box. #290

cbaakman opened this issue Dec 14, 2022 · 0 comments · Fixed by #292
Assignees
@cbaakman
Projects
Generalization - Task 2

Comments

@cbaakman
Copy link
Collaborator

Right now, the grid box has only one dimension setting: grid_size. This will determine the dimensions of the grid box in the x, y and z dimension.

Change this so that the user can set all three dimensions separately.
@cbaakman cbaakman created this issue from a note in Generalization - Task 2 (To Do) Dec 14, 2022
@cbaakman cbaakman self-assigned this Dec 14, 2022
Generalization - Task 2 automation moved this from To Do to Done Dec 15, 2022
@gcroci2 gcroci2 linked a pull request Dec 15, 2022 that will close this issue
feat: add the option to have a grid box of different x,y and z dimensions #292
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbaakman cbaakman

Labels
None yet
Projects
No open projects
Generalization - Task 2
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add the option to have a grid box of different x,y and z dimensions DeepRank/deeprank2
1 participant
@cbaakman