[Embedding] Enable construction of EmbeddingVariable with init_from_proto. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candyzone
reviewed
Mar 24, 2022
| @@ -690,20 +688,21 @@ class KvResourceImportV2Op: public OpKernel { | |||
| *ptr = new EmbeddingVar<TKey, TValue>(handle_self.name(), | |||
| storage_manager, | |||
| EmbeddingConfig(emb_index_ + block_num_ * slot_index_, emb_index_, | |||
| block_num_, slotnum, opname + "-primary", | |||
| block_num_, slot_num_, opname + "-primary", | |||
| steps_to_live_, filter_freq_, | |||
| max_freq_, l2_weight_threshold_, | |||
| layout_, max_element_size_, false_positive_probability_, | |||
| counter_type_, default_value_dim_)); | |||
| return (*ptr)->Init(default_values, default_value_dim_); | |||
There was a problem hiding this comment.
这里逻辑重复了
InitializeOp的逻辑跟这里保持一致
liutongxuan
approved these changes
Mar 25, 2022
lixy9474
added a commit
to lixy9474/DeepRec-1
that referenced
this pull request
Apr 14, 2022
liutongxuan
added a commit
to liutongxuan/DeepRec
that referenced
this pull request
Jun 7, 2022
…t_from_proto. (DeepRec-AI#128)" This reverts commit aded932.
shanshanpt
pushed a commit
to shanshanpt/DeepRec-1
that referenced
this pull request
Jul 14, 2022
…t_from_proto. (DeepRec-AI#128)" This reverts commit aded932.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.