Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix cycle dependency when build TFServing. #3

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

fuhailin
Copy link
Collaborator

1、解决如下BUILD文件中循环依赖问题

In the tensorflow/core BUILD file, a cycle dependence blocks DeepRec from building into a third-part repo:

.-> @DeepRec//tensorflow/core:framework
|   @DeepRec//tensorflow/core:framework_internal
|   @DeepRec//tensorflow/core:framework_internal_impl
|   @DeepRec//tensorflow/core:framework_internal_impl_hash_table
|   @DeepRec//tensorflow/core:core_cpu_lib
|   @DeepRec//tensorflow/core/grappler:grappler_item
|   @DeepRec//tensorflow/core/grappler:utils
`-- @DeepRec//tensorflow/core:framework
This cycle occurred because of a configuration option

2、DeepRec的三方库中同时引用@kafka和@kafka150,那么编译完成后的DeepRec头文件中将存在multiple definition of Kafka,无法对DeepRec进行link,因此需要去掉一个

3、It's better to add all new TensorFlow dependencies in workspace.bzl.

以上三个问题都阻止了将DeepRec作为third-party进行link,在此PR中一并进行修复

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2021

CLA assistant check
All committers have signed the CLA.

@liutongxuan liutongxuan added the bug Something isn't working label Dec 27, 2021
@liutongxuan liutongxuan changed the title fix cycle_deps [BUILD] Fix cycle dependency when build TFServing. Jan 6, 2022
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 14, 2022 02:08 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@fuhailin fuhailin temporarily deployed to PAI DLC January 18, 2022 09:41 Inactive
@liutongxuan liutongxuan merged commit c1b5aea into DeepRec-AI:main Jan 18, 2022
@fuhailin fuhailin deleted the Bugfix/cycle_deps branch January 19, 2022 02:43
francktcheng added a commit to 2sin18/DeepRec that referenced this pull request Feb 11, 2022
liutongxuan pushed a commit to liutongxuan/DeepRec that referenced this pull request Jun 13, 2022
xiaowan0322 added a commit to xiaowan0322/DeepRec that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants