Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH+API: Import lines twice, EVLs are raw lines without offset #218

Merged
merged 6 commits into from Sep 23, 2020
Merged

ENH+API: Import lines twice, EVLs are raw lines without offset #218

merged 6 commits into from Sep 23, 2020

Conversation

scottclowe
Copy link
Member

  • Move line offsetting and nearfield clipping from inference into import_lines_regions_to_ev function.
  • Output EVL files are now without offset and without nearfield clipping.
  • Offset line's colour and thickness can be separated with new API arguments; default to matching the regular line
  • Note added to offset line includes the (signed) offset distance.
  • Move mode function from echofilter.raw.utils to echofilter.utils.

@scottclowe
DOC: Correct thicknesses -> thickness
18cc70e
@scottclowe
RF: Move mode function from raw to primary utils.py
07c6cf2
@scottclowe
STY: Linewrap docstring
42d89cf
@scottclowe
ENH: Add evl_loader option to return line status values
a1be947
@scottclowe
ENH+RF: Import lines both with & w/out offset
5a35b19 
- Move line offsetting and nearfield clipping from inference into
  `import_lines_regions_to_ev` function.
- Output EVL files are now without offset and without nearfield
  clipping.
- Offset line's name, colour, thickness are inherited from regular
  line; note includes (signed) offset distance.
@scottclowe
API: Add ability to specify color and thickness of offset lines
0e55afe 
Default is still to match the un-offset line.
@scottclowe scottclowe merged commit d75fb9a into master Sep 23, 2020
@scottclowe scottclowe deleted the rf_import-lines-twice branch September 23, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@scottclowe