Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: Add requests to requirements #320

Merged
merged 1 commit into from
Nov 17, 2022
Merged

REL: Add requests to requirements #320

merged 1 commit into from
Nov 17, 2022

Conversation

scottclowe
Copy link
Member

We did not encounter the fact this was missing before because checkpoints had been cached when building with frozen requirements.

We did not encounter the fact this was missing before because
checkpoints had been cached when building with frozen requirements.
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 28.43% // Head: 28.07% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (1456964) compared to base (b4a0b40).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   28.43%   28.07%   -0.36%     
==========================================
  Files          45       45              
  Lines        5346     5346              
  Branches     1309     1309              
==========================================
- Hits         1520     1501      -19     
- Misses       3573     3593      +20     
+ Partials      253      252       -1     
Flag Coverage Δ
unittests 28.07% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echofilter/ui/checkpoints.py 34.73% <0.00%> (-8.99%) ⬇️
echofilter/path.py 60.78% <0.00%> (-3.93%) ⬇️
echofilter/ui/inference_cli.py 84.47% <0.00%> (-1.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottclowe scottclowe merged commit 312bdbf into master Nov 17, 2022
@scottclowe scottclowe deleted the rel_req-requests branch November 17, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant