Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Overwriting existing line #332

Merged
merged 2 commits into from
Nov 18, 2022
Merged

BUG: Overwriting existing line #332

merged 2 commits into from
Nov 18, 2022

Conversation

scottclowe
Copy link
Member

  • Fix the call to AsLineEditable(), which it turns out is a function in Python (differing from the Echoview documentation)
  • Use a try/except block around overwriting lines. If the OverwriteWith method fails, just delete the old line instead!

Closes #325.

@scottclowe scottclowe added the bug Something isn't working label Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 28.46% // Head: 27.96% // Decreases project coverage by -0.49% ⚠️

Coverage data is based on head (6517030) compared to base (2c2cd8f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   28.46%   27.96%   -0.50%     
==========================================
  Files          45       45              
  Lines        5407     5439      +32     
  Branches     1324     1332       +8     
==========================================
- Hits         1539     1521      -18     
- Misses       3611     3667      +56     
+ Partials      257      251       -6     
Flag Coverage Δ
unittests 27.96% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echofilter/inference.py 40.43% <0.00%> (-1.83%) ⬇️
echofilter/ui/checkpoints.py 34.97% <0.00%> (-9.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scottclowe scottclowe merged commit 397bef5 into master Nov 18, 2022
@scottclowe scottclowe deleted the bug_edit-line branch November 18, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overwriting lines already in Echoview file
1 participant