fix exception in subscribe #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionello
requested changes
Jun 19, 2024
lionello
reviewed
Jun 19, 2024
| if err != nil { | ||
| term.Debugf("error subscribing to service status: %v", err) | ||
| return err | ||
| } | ||
|
|
||
| serviceStatus := make(map[string]string, len(serviceList)) | ||
| for _, name := range serviceList { | ||
| serviceStatus[name] = string(cli.ServiceUnknown) |
There was a problem hiding this comment.
that name-normalization logic messes with my brain; are we getting normalized or non-normalized names? I think we should remove the normalizedServiceNameToServiceName map and just make sure we internally only use the normalized ones. We can normalize any strings the users passes to use, either on cmd line or in compose.
lionello
approved these changes
Jun 19, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #480 #479