Filtering Performance: Add opt-in setting for converting to string ba… #10038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
New Migration
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Powered by DryRun Security |
blakeaowens
approved these changes
Apr 26, 2024
hblankenship
pushed a commit
to hblankenship/django-DefectDojo
that referenced
this pull request
Apr 26, 2024
DefectDojo#10038) * Filtering Performance: Add opt-in setting for converting to string based filters * Fix ruff error * Fix Flake8 * Update unit tests.. * Correct filter
Maffooch
added a commit
to Maffooch/django-DefectDojo
that referenced
this pull request
Apr 28, 2024
Maffooch
added a commit
that referenced
this pull request
Apr 29, 2024
mwager
added a commit
to mwager/django-DefectDojo
that referenced
this pull request
Apr 30, 2024
… kiuwan-sca * 'kiuwan-sca' of github.com:mwager/django-DefectDojo: Update versions in application files Product Metrics: Performance Enhancements (DefectDojo#10059) String Based Filtering: Follow on for DefectDojo#10038 (DefectDojo#10050) update semgrep tests (DefectDojo#10058) Jira Webhook: Reorg logging and responses (DefectDojo#10049) Similar Findings: Create Toggle (DefectDojo#10047) Bump social-auth-app-django from 5.4.0 to 5.4.1 (DefectDojo#10026) Update versions in application files Update versions in application files Updated DryRun Security config (DefectDojo#10037) Filtering Performance: Add opt-in setting for converting to string ba… (DefectDojo#10038) Updates to semgrep parser (DefectDojo#10033) Update versions in application files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the finding filters will query all products type, products, engagements, and all tags for all items that can be tagged. When loading the all finding pages, this will end up querying a large portion of the database.
This PR adds an opt in setting in the system settings to convert these filter options to string fields in order to avoid making these queries when they are not specifically used
[sc-5650]