Fix numerical sorting in the old UI for Active/Verified findings #10045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include dojo_sort snippet in findings_count table header add findings_count annotation to include column in query
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🔴 Risk threshold exceeded. Adding a reviewer if one is configured in notification list: @mtesauro @grendel513 Powered by DryRun Security |
Maffooch
approved these changes
Apr 26, 2024
cneill
approved these changes
Apr 26, 2024
blakeaowens
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-5627]
As #6629 describes, there are views where sorting is made "lexicographically." The main problem I found is that sorting is performed by the front end (the page doesn't reload on sorting). Tables that don't perform sorting on the backend, like the ones displayed at
/product/{pid}/engagements,will need another approach.For the
All productsview, using a filter for findings_count on the backend allows us to sort numerically and sort over the complete dataset instead of being limited by the rows shown on the current page.By implementing this change, we directly address the issue outlined in #8127, providing a more efficient sorting and filtering mechanism for the displayed data.