Setting status code on 400/500 errors #10164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because DefectDojo uses a custom error handler for 400/500 errors that does not set a status code, 200 status codes will be returned even when an exception is raised. This means that Django logs those exceptions at the INFO level rather than a more appropriate
WARNING
/ERROR
level. This patch simply sets the status codes to 400/500.Test results
In my testing, 500 status codes are now returned when exceptions are raised, and those requests are now logged at an
ERROR
level.[sc-5912]