Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Repo field #1177

Merged
merged 2 commits into from May 28, 2019

Conversation

@dr3dd589
Copy link
Member

dr3dd589 commented May 24, 2019

changed Repo model to URLField from CharField.
DB migration file added.

When submitting a pull request, please make sure you have completed the following checklist:

  • Your code is flake8 compliant (DefectDojo's code isn't currently flake8 compliant, but we're trying to correct that.)
  • If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
  • Model changes should include the necessary migrations in the dojo/dd_migrations folder.
  • Add applicable tests to the unit tests.
dr3dd589 added 2 commits May 24, 2019
@valentijnscholten

This comment has been minimized.

Copy link
Contributor

valentijnscholten commented May 28, 2019

What if the existing data in this column contains data that doesn't pass the https://docs.djangoproject.com/en/2.2/ref/validators/#django.core.validators.URLValidator used by the URLField? Or are there other checks in DD which should have prevented this already?

@adracea adracea requested a review from aaronweaver May 28, 2019
@dr3dd589

This comment has been minimized.

Copy link
Member Author

dr3dd589 commented May 28, 2019

hello, @valentijnscholten I have tested it locally and it does not affect on existing data that does not validate URLValidator rule.

@devGregA devGregA self-requested a review May 28, 2019
@devGregA devGregA merged commit cf9708a into DefectDojo:dev May 28, 2019
4 checks passed
4 checks passed
AccessLint Review complete
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - components/package.json (aaronweaver (GitHub marketplace)) No manifest changes detected
security/snyk - requirements.txt (aaronweaver (GitHub marketplace)) No manifest changes detected
@dr3dd589 dr3dd589 deleted the dr3dd589:fix_repo_field branch Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.