Fixes and add missing index for simple search #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madchap
approved these changes
Oct 3, 2020
madchap
reviewed
Oct 3, 2020
valentijnscholten
added
New Migration
|
Just pulled it locally over a 750K findings instance, works much better, thanks :-) |
Maffooch
approved these changes
Oct 5, 2020
valentijnscholten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR because the previous one (#2952) was messed up by the merge/push problem we had on the dev branch.
Search / autocomplete related:
component_namefieldI think with the index it still performs OK even with 750k findings, but probably not usefull in that case to send 5MB of javascript to the client. Might need a better autocomplete in the future, ajax based.